MM-16444 - Adding usernames back to compact view

[asaadmahmood]

Summary

MM-16444 - Adding usernames back to compact view

Ticket Link

https://mattermost.atlassian.net/browse/MM-16444

[jespino]

Why not keep it as before and add here something like:

let userProfile = null;
if (this.props.compactDisplay) {
            userProfile = (
                <UserProfile
                    userId={post.user_id}
                    isBusy={this.props.isBusy}
                    isRHS={true}
                    hasMention={true}
                />
            );
}

and then, the previous approach with:

if (!isConsecutivePost) {
            userProfile = (
                <UserProfile
                    userId={post.user_id}
                    isBusy={this.props.isBusy}
                    isRHS={true}
                    hasMention={true}
                />
            );
            ...

This way you will have better performance when you are not using the compact view. I'm not 100% sure about when is rendered the popover stuff, but if is rendered at the same time, it will be a lot of performance invested there.

[jespino]

I confirmed that is not a big deal because the Popover is render on visualization. Anyway, feel free to add my proposed optimization, when you multiply that component for 100 for example in a long thread, probably it has some impact.

[jespino]

LGTM

[jespino]

LGTM. Thanks! :)

[asaadmahmood]

One minor change left, the timestamps need to appear at all times.

[asaadmahmood]

Done

[jespino]

LGTM

[enahum]

@asaadmahmood @jespino I'm not following what is happening here

[enahum]

@asaadmahmood explained to me offline

[enahum]

@jespino the cherry picking is conflicting with some of your previous work, can you take a look at this please

[jespino]

@enahum actually, I'm not 100% sure about this bug really affects 5.13, looks like was introduced as part of an optimization that went into master, but not into 5.13. Can we confirm that the bug was in 5.13?

[asaadmahmood]

@jespino This bug exists on community daily, which is on 5.13.

[jespino]

@asaadmahmood community-daily is master (I think)

[enahum]

Yup community daily is master

[asaadmahmood]

Tested https://community-release.mattermost.com/, which seems to be 5.13. Doesn't seem to repro on that. So should this be moved to 5.14?

[jespino]

Yes, I think so, it doesn't need cherry-pick, it was broken as part of the optimization to not paint things when not needed in the RHS.