Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-16282: Removing not necesary code #2964

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Jun 13, 2019

Summary

Removing unnecessary and failing code.

This was already fixed in master but in a PR that include more changes, so I make the PR directly to be merged against release-5.12.

Ticket Link

MM-16282

@jespino jespino added the 2: Dev Review Requires review by a core commiter label Jun 13, 2019
@amyblais amyblais added this to the v5.12.0 milestone Jun 13, 2019
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 2: Dev Review Requires review by a core commiter labels Jun 13, 2019
@jwilander jwilander merged commit 0de2540 into mattermost:release-5.12 Jun 13, 2019
@jespino jespino deleted the MM-16282 branch June 13, 2019 13:25
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 13, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 13, 2019
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants