This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-8104: @here should not be added to search on clicking @ icon to display mentions #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pressed, regardless of notification preferences. Tidied up search term removal code to avoid unecessary whitespace between search terms
MusikPolice
commented
Nov 13, 2017
|
|
||
| const indexOfHere = termKeys.indexOf('@here'); | ||
| if (indexOfHere !== -1) { | ||
| termKeys.splice(indexOfHere, 1); |
There was a problem hiding this comment.
This is the actual bug fix - suspect that we changed default mention keys to include @here, but didn't update this code. The rest of the change is just removing terms from the array, rather than replacing them with empty string to avoid building up unnecessary whitespace when the array elements are joined on line 492
There was a problem hiding this comment.
I've checked this issue and it might be related to this added key here - https://github.com/mattermost/mattermost-webapp/blob/master/stores/user_store.jsx#L464
jwilander
approved these changes
Nov 13, 2017
saturninoabril
approved these changes
Nov 13, 2017
saturninoabril
added
the
4: Reviews Complete
jasonblais
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly removed @here from search terms when the mentions button is pressed, regardless of notification preferences. Tidied up search term removal code to avoid unnecessary whitespace between search terms
Ticket Link
https://mattermost.atlassian.net/browse/PLT-8104
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)