This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-16029 IE11: image attachments aren't displayed #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudheerDev
added
Work in Progress
sudheerDev
added
2: Dev Review
enahum
approved these changes
Jun 6, 2019
sudheerDev
changed the title
migbot
added
4: Reviews Complete
sudheerDev
removed
the
4: Reviews Complete
sudheerDev
commented
Jun 6, 2019
enahum
approved these changes
Jun 6, 2019
sudheerDev
added
4: Reviews Complete
sudheerDev
added a commit
that referenced
this pull request
Jun 6, 2019
sudheerDev
added
CherryPick/Done
lindy65
added
Tests/Not Needed
Wipeout55
pushed a commit
to Wipeout55/mattermost-webapp
that referenced
this pull request
Jun 11, 2019
* MM-16029 IE11: Single image attachments aren't displayed * Remove fill-content css prop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With display none to image IE does not request for image so it never loads to trigger onLoad event.
So changing it to be absolutely positioned element with visibility hidden so it is not visible and does not take any space when svg is in place for placeholder.
Ticket Link
https://mattermost.atlassian.net/browse/MM-16029
https://mattermost.atlassian.net/browse/MM-16028
https://mattermost.atlassian.net/browse/MM-16027
https://mattermost.atlassian.net/browse/MM-16100