This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-16007] Fix JS errors in system console and channel intro message #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
commented
Jun 4, 2019
| text: PropTypes.string.isRequired, | ||
| text: PropTypes.oneOfType([ | ||
| PropTypes.string, | ||
| PropTypes.object, |
There was a problem hiding this comment.
Other help text are passed with elements like security help text --> here
saturninoabril
commented
Jun 4, 2019
| @@ -34,7 +34,7 @@ export default class ChannelIntroMessage extends React.PureComponent { | |||
| channelProfiles: PropTypes.array.isRequired, | |||
| enableUserCreation: PropTypes.bool, | |||
| isReadOnly: PropTypes.bool, | |||
| teamIsGroupConstrained: PropTypes.bool.isRequired, | |||
| teamIsGroupConstrained: PropTypes.bool, | |||
There was a problem hiding this comment.
team.group_constrained is sometimes null if not set. So, either make this as not required or wrapped it with Boolean(team.group_constrained).
amyblais
added
the
CherryPick/Approved
bradjcoughlin
approved these changes
Jun 4, 2019
mkraft
approved these changes
Jun 6, 2019
mkraft
added
4: Reviews Complete
saturninoabril
added a commit
that referenced
this pull request
Jun 6, 2019
saturninoabril
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
Wipeout55
pushed a commit
to Wipeout55/mattermost-webapp
that referenced
this pull request
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix JS errors in system console and channel intro message.
Ticket Link
Jira ticket: MM-16007