Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15403 Fixes highlight for date separators and new messages line on post hover #2894

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

sudheerDev
Copy link
Contributor

@sudheerDev sudheerDev commented Jun 1, 2019

  • Fixes a regression with consecutive posts padding

Screenshot 2019-06-01 at 3 55 10 PM

  • Changes height to 1px for date separator and new message line as height is needed for virt list to correct scroll to position when new messages separator exists

https://mattermost.atlassian.net/browse/MM-15403

Related Pull Requests

Regression caused by #2806

… post hover

 * Fixes a regression with consecutive posts padding
 * Changes height to 1px for date separator and new message line as it
   is causing problems with scroll corrections
@sudheerDev sudheerDev added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 1, 2019
@sudheerDev sudheerDev added this to the v5.12.0 milestone Jun 1, 2019
Copy link
Member

@svelle svelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jun 1, 2019
@sudheerDev sudheerDev merged commit 84a7ac1 into mattermost:master Jun 1, 2019
@sudheerDev sudheerDev deleted the MM-15403 branch June 1, 2019 16:17
sudheerDev added a commit that referenced this pull request Jun 1, 2019
… post hover (#2894)

* Fixes a regression with consecutive posts padding
 * Changes height to 1px for date separator and new message line as it
   is causing problems with scroll corrections
@sudheerDev sudheerDev added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 1, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 3, 2019
@ogi-m ogi-m added the Tests/Not Needed Does not require new release tests label Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
6 participants