This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-12320 - Change "about" section references to use the site name when it is configured #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing fork up to date
4 tasks
jespino
reviewed
May 28, 2019
jespino
reviewed
May 28, 2019
components/admin_console/admin_navbar_dropdown/admin_navbar_dropdown.jsx
Outdated
Show resolved
Hide resolved
jespino
reviewed
May 28, 2019
jespino
reviewed
May 28, 2019
jespino
suggested changes
May 28, 2019
enahum
approved these changes
May 28, 2019
| @@ -211,7 +211,8 @@ export default class AboutBuildModal extends React.PureComponent { | |||
| > | |||
| <FormattedMessage | |||
| id='about.title' | |||
| defaultMessage='About Mattermost' | |||
| values={{appTitle: config.SiteName || 'Mattermost'}} | |||
There was a problem hiding this comment.
just to point out this is the same explanation as in the mobile PR, 0/5 if you change it or not
enahum
added
4: Reviews Complete
mkraft
reviewed
May 29, 2019
lindy65
removed
the
4: Reviews Complete
amyblais
added
Docs/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Site Name is configured under "System Console > Custom Branding > Site Name:
update Main Menu from "About Mattermost" to "About [Site Name]"
update About modal heading "About Mattermost" to "About [Site Name]" (see attached image)
This should apply to desktop app, Webapp and RN.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-12320
Related Pull Requests
MM-12320 - Change "about" section references to use the site name when it is configured mattermost-mobile#2835