PLT-8089: Hides "Password updated successfully" flash after login attempt. #285
Conversation
|
Spinmint test server created at: https://i-003bc0bcd2cd01598.spinmint.com Test Account 1: Email: Test Account 2: Email: Instance ID: i-003bc0bcd2cd01598 |
|
Spinmint test server destroyed |
| const {location} = this.props; | ||
| const newQuery = location.search.replace(/(extra=password_change)&?/i, ''); | ||
| if (newQuery !== location.search) { | ||
| browserHistory.replace(`${location.pathname}${newQuery}${location.hash}`); |
There was a problem hiding this comment.
This doesn't cause any problems if removing the extra parameter would cause the link to end in ? or ?something=else& would it?
There was a problem hiding this comment.
@hmhealey Good eye. I didn't bother removing the trailing ? or & when I was writing it because I'm not aware of those characters trailing a path or query (respectively) causing any issues. If you're aware of any reason we should be concerned let me know and I can make a change.
There was a problem hiding this comment.
There's nothing I'm aware of, so this should be fine then
|
@jasonblais @hmhealey I have rebased onto master to get ride of those extra commits.
@jasonblais I think we're probably good to just do dev review. |
Summary
Removes the
extra=password_changequery parameter upon submitting a login form so that the "Password updated successfully" flash message disappears in cases where the route does not redirect.Ticket Link
[Please link the GitHub issue or Jira ticket this PR addresses.]
Jira PLT-8089
Checklist
make check-styleto check for style errors (required for all pull requests)