Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-11287] Add support for plus sign and period/dot in custom URL schemes (#9155) #2842

Merged
merged 2 commits into from
May 27, 2019
Merged

[MM-11287] Add support for plus sign and period/dot in custom URL schemes (#9155) #2842

merged 2 commits into from
May 27, 2019

Conversation

letsila
Copy link
Contributor

@letsila letsila commented May 23, 2019 •
edited
Loading

@letsila letsila force-pushed the MM-11287 branch 2 times, most recently from f5aa89b to ee3da83 Compare May 23, 2019 19:01
@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label May 24, 2019
hmhealey
hmhealey suggested changes May 24, 2019
View reviewed changes
utils/text_formatting_links.test.jsx Outdated Show resolved Hide resolved
lieut-data
lieut-data approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but agree with @hmhealey's feedback.

@letsila
Copy link
Contributor Author

letsila commented May 24, 2019

Fixed

lieut-data
lieut-data approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- @letsila, can you avoid force pushes as per https://developers.mattermost.com/blog/submitting-great-prs/#4-avoid-force-pushing? We squash all PRs anyway, so rebasing just makes the review process harder.

@letsila
Copy link
Contributor Author

letsila commented May 27, 2019 •
edited
Loading

@lieut-data sorry for that. I will avoid force push in the future.

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 27, 2019
@hmhealey hmhealey added this to the v5.14.0 milestone May 27, 2019
@hmhealey hmhealey merged commit 73ebe16 into mattermost:master May 27, 2019
@hmhealey hmhealey mentioned this pull request May 27, 2019
Merged
@letsila letsila deleted the MM-11287 branch May 28, 2019 09:08
@saturninoabril saturninoabril mentioned this pull request Jun 6, 2019
Merged
@lindy65 lindy65 removed the 4: Reviews Complete All reviewers have approved the pull request label Jun 7, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jul 16, 2019
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@letsila @lieut-data @hmhealey @lindy65 @hanzei @lindalumitchell @amyblais