Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15340 provide InteractiveDialog hook to webapp plugins #2838

Merged
merged 12 commits into from
Jun 7, 2019
Merged

MM-15340 provide InteractiveDialog hook to webapp plugins #2838

merged 12 commits into from
Jun 7, 2019

Conversation

scottleedavis
Copy link
Contributor

@scottleedavis scottleedavis commented May 22, 2019 •
edited
Loading

Summary

Provides functionality to trigger an InteractiveDialog via a webapp plugin.

Ticket Link

Fixes mattermost/mattermost#10900

@scottleedavis scottleedavis mentioned this pull request May 22, 2019
Closed
@hanzei hanzei requested review from jwilander and cpoile May 22, 2019 21:22
@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label May 22, 2019
cpoile
cpoile approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottleedavis !

After reading the thread that prompted this HW ticket, I'm pretty sure this doesn't cause a security problem. But I'll defer to @jwilander for the final say.

@scottleedavis scottleedavis changed the title MM-15340 remove dialog trigger id check MM-15340 provide InteractiveDialog hook to webapp plugins Jun 4, 2019
@scottleedavis
Copy link
Contributor Author

@jwilander Following your recommendation I created openInteractiveDialog in the plugin registry functions, and confirmed that a plugin action can trigger this function. https://github.com/scottleedavis/mattermost-plugin-remind/blob/issue_73_eval/webapp/src/actions.js#L11-L85

@jwilander jwilander requested a review from hanzei June 6, 2019 15:04
jwilander
jwilander reviewed Jun 6, 2019
View reviewed changes
plugins/registry.js Outdated Show resolved Hide resolved
jwilander
jwilander approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jun 7, 2019
@hanzei hanzei added this to the v5.14.0 milestone Jun 7, 2019
@hanzei hanzei merged commit f055b7e into mattermost:master Jun 7, 2019
Wipeout55 pushed a commit to Wipeout55/mattermost-webapp that referenced this pull request Jun 11, 2019
@scottleedavis @Wipeout55
MM-15340 provide InteractiveDialog hook to webapp plugins (mattermost…
7d20363 
…#2838)

Provides functionality to trigger an InteractiveDialog via a webapp plugin.
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation labels Jul 16, 2019
@aaronrothschild
Copy link
Contributor

Thanks @scottleedavis for the docs on this at: mattermost/mattermost-plugin-demo#52

@aaronrothschild aaronrothschild removed their assignment Aug 16, 2019
@aaronrothschild aaronrothschild added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marianunez marianunez marianunez left review comments

@cpoile cpoile cpoile approved these changes

@jwilander jwilander jwilander approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Done Required documentation has been written
Projects
None yet
Milestone
v5.14.0
7 participants
@scottleedavis @aaronrothschild @marianunez @cpoile @jwilander @hanzei @amyblais