Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15586 Bot tag missing for bots in channel switcher #2815

Merged
merged 5 commits into from
May 24, 2019
Merged

MM-15586 Bot tag missing for bots in channel switcher #2815

merged 5 commits into from
May 24, 2019

Conversation

scottleedavis
Copy link
Contributor

Summary

Removes a width 0 style on the bot name in the channel switch suggestion list which puts the BOT badge at the end.

Ticket Link

Fixes mattermost/mattermost#10865

@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server 1: PM Review Requires review by a product manager labels May 19, 2019
@amyblais amyblais added this to the v5.12.0 milestone May 20, 2019
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label May 20, 2019
@hanzei hanzei requested a review from jasonblais May 21, 2019 21:18
@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels May 22, 2019
jasonblais
jasonblais suggested changes May 22, 2019
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @scottleedavis - sorry that it took me this long to review it - but looks like I'm not seeing the bot tag next to the bot in the channel switcher

image

@jasonblais jasonblais added the Awaiting Submitter Action Blocked on the author label May 22, 2019
@scottleedavis
Copy link
Contributor Author

@jasonblais I was able to replicate, but only for user created bots. The BOT badge shows up for plugin created bots. (replicated on spinmint as well as local)

Screen Shot 2019-05-22 at 3 49 50 PM

I will look further why the badge is not showing up for user created bots.

@jasonblais
Copy link
Contributor

It doesn't show up for me for the Remind plugin, on the above spinmint at least

image

@scottleedavis
Copy link
Contributor Author

I believe If you have no message history with the bot, not bot tag. However if you have any DM history the BOT tag shows up. There is some logic that only adds the BOT tags if a DM has occurred.

Screen Shot 2019-05-22 at 4 01 07 PM

@jasonblais
Copy link
Contributor

@scottleedavis Good find. In fact, it seems as soon as the DM channel with the bot is created in the system, the BOT tag shows up in the channel switcher

@scottleedavis
Copy link
Contributor Author

@jasonblais I pushed a changed that I believe solves the non-dm channel with a bot.

Screen Shot 2019-05-22 at 4 20 26 PM

@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Awaiting Submitter Action Blocked on the author Setup Old Test Server Triggers the creation of a test server labels May 23, 2019
jasonblais
jasonblais approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Also tested other channel types (public/private/DM/GM) in the channel switcher and see no issues. Approving.

image

image

@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels May 23, 2019
deanwhillier
deanwhillier approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@deanwhillier deanwhillier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@deanwhillier deanwhillier added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 24, 2019
@deanwhillier deanwhillier merged commit d1d1929 into mattermost:master May 24, 2019
deanwhillier pushed a commit that referenced this pull request May 24, 2019
@scottleedavis @deanwhillier
MM-15586 Bot tag missing for bots in channel switcher (#2815)
a519a0e 
* removed width 0 display name

* handle non DM bots in channel search
@deanwhillier deanwhillier added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 24, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 24, 2019
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deanwhillier deanwhillier deanwhillier approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

@jasonblais jasonblais jasonblais approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.12.0
6 participants
@scottleedavis @jasonblais @deanwhillier @asaadmahmood @amyblais @DHaussermann