Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix select default channel #2801

Merged
merged 3 commits into from
May 17, 2019
Merged

Fix select default channel #2801

merged 3 commits into from
May 17, 2019

Conversation

enahum
Copy link
Contributor

@enahum enahum commented May 15, 2019

Summary

There was a PR that introduced a bug when selecting the default channel as it was using the selector getChannelByName instead of the utility of the same name thus it selected the first available channel that matched the name regardless of the team that it actually belonged.

Related Pull Requests

@enahum enahum added 2: Dev Review Requires review by a core commiter Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels May 15, 2019
@enahum enahum added this to the v5.12.0 milestone May 15, 2019
@enahum enahum requested review from jespino and hmhealey May 15, 2019 18:51
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 16, 2019
@enahum enahum removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label May 16, 2019
@jespino jespino merged commit ae81a37 into master May 17, 2019
@jespino jespino deleted the fix-default-channel branch May 17, 2019 11:09
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 17, 2019
composednitin pushed a commit to composednitin/mattermost-webapp that referenced this pull request May 22, 2019
* Fix select default channel

* update mattermost-redux
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants