This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-15227 Permalink is not loading more posts into the view when reacheded to the top #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
approved these changes
May 15, 2019
hmhealey
approved these changes
May 16, 2019
hmhealey
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
composednitin
pushed a commit
to composednitin/mattermost-webapp
that referenced
this pull request
May 22, 2019
lindy65
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selector
getPostIdsAroundPosttakes options arguments for slicing the required postshttps://github.com/mattermost/mattermost-redux/blob/master/src/selectors/entities/posts.js#L131-L134
As with virtualised list we can return the entire post chunk so adding
-1index as option so selector can return all the posts in the chunk. With bi-directional scrolling we can add-1forpostsAfterCountas well given we add the initial range to mount for virtualised listhttps://mattermost.atlassian.net/browse/MM-15227