Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15457 E2E - Fix integrations Cypress spec #2784

Merged
merged 5 commits into from
May 14, 2019

Conversation

thekiiingbob
Copy link
Contributor

Summary

  • Update the integrations test to use better selectors.
  • Had to add ID's to a handful of elements for the test to use.
  • Instead of driving UI to allow these settings, now use an API call.

Ticket Link

JIRA

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label May 14, 2019
Copy link
Contributor

@reflog reflog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, but I think we should leave the support functions in ui_commands.js , they might come in handy later on. At least selectOption and toIntegrationSettings

@thekiiingbob
Copy link
Contributor Author

@reflog I want to abstract them out, but they should probably live somewhere else rather than off of cy. cy was getting a bit polluted with custom commands that were really only used for one test. Don't worry though, these are on my radar to fix :)

@reflog
Copy link
Contributor

reflog commented May 14, 2019

💪

@reflog reflog merged commit 1f2cbf3 into mattermost:master May 14, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 2: Dev Review Requires review by a core commiter labels May 15, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 15, 2019
@thekiiingbob thekiiingbob deleted the MM-15457 branch June 28, 2019 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants