This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-15451] Fix failing E2E tests due to recent changes #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
approved these changes
May 9, 2019
saturninoabril
commented
May 9, 2019
| @@ -112,7 +112,7 @@ describe('Teams Suite', () => { | |||
|
|
|||
| it('TS14633 Leave all teams', () => { | |||
| // 1. Login and go to / | |||
| cy.apiLogin('user-2'); | |||
| cy.apiLogin('user-3'); | |||
There was a problem hiding this comment.
Not related to the issue but changed anyway. Since the original user-2 is leaving teams, other tests that's using such user will fail (in case this test runs before that).
Long term might be to have this test rejoin the teams on after hook. Will address that separately.
thekiiingbob
approved these changes
May 10, 2019
hanzei
added
4: Reviews Complete
lindy65
added
Tests/Not Needed
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed failing tests of the following:
By fixing the way we're getting last post ID (
cy.getLastPostId) --> affected by the recent change related to virtualized post list.By changing
#accountSettingsTitleto#accountSettingsModalLabel--> affected by recent change on aria labelsTicket Link
Jira: MM-15451