Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Migrate audio_video_preview.jsx to be pure and use Redux #7678 #273

Merged
merged 4 commits into from
Nov 10, 2017
Merged

Migrate audio_video_preview.jsx to be pure and use Redux #7678 #273

merged 4 commits into from
Nov 10, 2017

Conversation

deveshjadon98
Copy link
Contributor

Summary

audio_video_preview.jsx is made pure and unit test case are written in audio_video_preview.test.jsx

Ticket Link

mattermost/mattermost#7678

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label Nov 10, 2017
saturninoabril
saturninoabril approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Note: I can't find a way to test HTML

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 10, 2017
@saturninoabril saturninoabril merged commit 14a1f78 into mattermost:master Nov 10, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 14, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 4, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@jwilander @hmhealey
PLT-7799 Mock server for all unit tests (#273)
5bed347 
* Mock server for all unit tests

* Update README

* Add mocking for new test

* Various fixes

* Fixes after rebase
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@jwilander
PLT-7799 Mock server for all unit tests (#273)
2c9b2ec 
* Mock server for all unit tests

* Update README

* Add mocking for new test

* Various fixes

* Fixes after rebase
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deveshjadon98 @jwilander @saturninoabril @jasonblais @lindalumitchell @KishoreFartiyal