Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14903: Adds messaging to group members dropdown. #2729

Merged
merged 4 commits into from
May 3, 2019
Merged

MM-14903: Adds messaging to group members dropdown. #2729

merged 4 commits into from
May 3, 2019

Conversation

mkraft
Copy link
Contributor

@mkraft mkraft commented Apr 30, 2019

Summary

Adds messaging about members being managed by groups.

Ticket Link

https://mattermost.atlassian.net/browse/MM-14903

Screenshot

Screen Shot 2019-04-30 at 3 05 05 PM

@mkraft mkraft added the 2: Dev Review Requires review by a core commiter label Apr 30, 2019
@mkraft mkraft added Work in Progress Not yet ready for review and removed 2: Dev Review Requires review by a core commiter labels Apr 30, 2019
jespino
jespino approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mgdelacroix
mgdelacroix approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@mgdelacroix mgdelacroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpanato cpanato added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels May 2, 2019
@cpanato
Copy link
Contributor

cpanato commented May 2, 2019

setting test just for some tests with mattermod, please ignore

@cpanato cpanato added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels May 2, 2019
@mkraft mkraft removed the Work in Progress Not yet ready for review label May 3, 2019
@mkraft mkraft merged commit 3d29771 into master May 3, 2019
@mkraft mkraft deleted the MM-14903 branch May 3, 2019 17:12
@lindalumitchell lindalumitchell added this to the v5.12.0 milestone May 17, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 17, 2019
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgdelacroix mgdelacroix mgdelacroix approved these changes

@jespino jespino jespino approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.12.0
6 participants
@mkraft @cpanato @mgdelacroix @jespino @lindalumitchell @amyblais