Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15080 Use event emitter to scroll to bottom when sending post #2728

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

hmhealey
Copy link
Member

As I mentioned before, inferring this from the redux state is really, really difficult, so we're just going to use an event to trigger the post list to scroll to the bottom because it's very straightforward to do that.

Ticket Link

https://mattermost.atlassian.net/browse/MM-15080

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Apr 30, 2019
@hmhealey hmhealey added this to the v5.12.0 milestone Apr 30, 2019
Copy link
Contributor

@sudheerDev sudheerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudheerDev
Copy link
Contributor

we're just going to use an event to trigger the post list to scroll to the bottom because it's very straightforward to do that
@hmhealey that is fine i think for IE11 i have to add similar logic anyway

@saturninoabril saturninoabril merged commit 2837bb3 into master Apr 30, 2019
@saturninoabril saturninoabril deleted the mm15080 branch April 30, 2019 16:53
@saturninoabril saturninoabril removed the 2: Dev Review Requires review by a core commiter label Apr 30, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 17, 2019
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants