Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-15046: Adding AnyTeamPermissionGate and used with emojis permissions #2696

Merged
merged 2 commits into from
Apr 25, 2019
Merged

MM-15046: Adding AnyTeamPermissionGate and used with emojis permissions #2696

merged 2 commits into from
Apr 25, 2019

Conversation

jespino
Copy link
Member

@jespino jespino commented Apr 24, 2019

Summary

Emojis permissions have the special property of been granted from any team
admin role, so if you have the permission at any team, you are able to do the
actions in all the teams. I added a new permissions gate call
"AnyTeamPermissionGate" which deal with that and used for the emojis
permissions.

Ticket Link

MM-15046

@jespino jespino added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 24, 2019
@jespino jespino added this to the v5.11.0 milestone Apr 24, 2019
gabrieljackson
gabrieljackson approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, but looks good!

...missions_gates/any_team_permission_gate/__snapshots__/any_team_permission_gate.test.jsx.snap Outdated Show resolved Hide resolved
...missions_gates/any_team_permission_gate/__snapshots__/any_team_permission_gate.test.jsx.snap Outdated Show resolved Hide resolved
components/permissions_gates/any_team_permission_gate/any_team_permission_gate.test.jsx Outdated Show resolved Hide resolved
@DSchalla
Copy link
Member

Aside from the build error, looks good to me. 👍

@jespino
Copy link
Member Author

jespino commented Apr 25, 2019

The build error is not a build error ;) circleCI is not working yet.

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 25, 2019
@jespino jespino merged commit c7f9390 into mattermost:master Apr 25, 2019
@jespino jespino deleted the MM-15046 branch April 25, 2019 20:40
jespino added a commit that referenced this pull request Apr 25, 2019
@jespino
MM-15046: Adding AnyTeamPermissionGate and used with emojis permissio…
892f96f 
…ns (#2696)

* MM-15046: Adding AnyTeamPermissionGate and used with emojis permissions

* Addressing PR review comments
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Apr 26, 2019
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Apr 26, 2019
@hanzei hanzei added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrieljackson gabrieljackson gabrieljackson approved these changes

@DSchalla DSchalla DSchalla approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.11.0
6 participants
@jespino @DSchalla @gabrieljackson @hanzei @amyblais @DHaussermann