Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14741 Add default option to post action dropdown #2677

Merged
merged 2 commits into from
Apr 22, 2019
Merged

MM-14741 Add default option to post action dropdown #2677

merged 2 commits into from
Apr 22, 2019

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Apr 18, 2019

This PR is pretty straightforward. This value starts selected in the dropdown, allowing integrations to "save" a value which we wanted for the NPS plugin.

Server PR: mattermost/mattermost#10659
Mobile PR: mattermost/mattermost-mobile#2724

Ticket Link

https://mattermost.atlassian.net/browse/MM-14741

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Apr 18, 2019
@hmhealey hmhealey added this to the v5.12.0 milestone Apr 18, 2019
@hmhealey hmhealey requested review from levb and jwilander April 18, 2019 20:05
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hmhealey hmhealey added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Apr 18, 2019
@crspeller crspeller added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 19, 2019
@levb levb removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Apr 22, 2019
@levb levb merged commit c1086d2 into master Apr 22, 2019
@hanzei hanzei deleted the m14741 branch April 23, 2019 10:12
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 16, 2019
@lindy65 lindy65 added Tests/Done Release tests have been written and removed 4: Reviews Complete All reviewers have approved the pull request labels May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
6 participants