This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14896 Add rootCapture=true to MenuWrapper listeners #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
mkraft
approved these changes
Apr 8, 2019
jespino
added
4: Reviews Complete
hmhealey
added a commit
that referenced
this pull request
Apr 10, 2019
hmhealey
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
TranMacTien
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on react-overlay's RootCloseWrapper which sets it so that we check if the menu needs to close before handling any other event handlers which may unmount the menu.
https://github.com/react-bootstrap/react-overlays/blob/master/src/RootCloseWrapper.js#L57
Ticket Link
https://mattermost.atlassian.net/browse/MM-14896