Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-14826] Disable Safari spellcheck on quick switcher #2597

Merged
merged 1 commit into from
Apr 3, 2019
Merged

[MM-14826] Disable Safari spellcheck on quick switcher #2597

merged 1 commit into from
Apr 3, 2019

Conversation

gabrieljackson
Copy link
Contributor

This change disables the Safari spellcheck suggestions on the
quick channel switcher input. These suggestions could correct
actual channel and user names.

https://mattermost.atlassian.net/browse/MM-14826

@gabrieljackson
[MM-14826] Disable Safari spellcheck on quick switcher
9af3afd 
This change disables the Safari spellcheck suggestions on the
quick channel switcher input. These suggestions could correct
actual channel and user names.
lieut-data
lieut-data approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was easy! Nice work, @gabrieljackson!

@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label Apr 3, 2019
jwilander
jwilander approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 3, 2019
@jwilander jwilander merged commit 1a2d8d2 into mattermost:master Apr 3, 2019
@lindy65 lindy65 removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 12, 2019
@lindy65 lindy65 added this to the v5.11.0 milestone Apr 13, 2019
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Apr 22, 2019
hanzei pushed a commit that referenced this pull request Apr 24, 2019
@gabrieljackson @hanzei
[MM-14826] Disable Safari spellcheck on quick switcher (#2597)
17eaad7 
This change disables the Safari spellcheck suggestions on the
quick channel switcher input. These suggestions could correct
actual channel and user names.
@hanzei hanzei added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone 4: Reviews Complete All reviewers have approved the pull request and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 24, 2019
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Apr 24, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@jwilander jwilander jwilander approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.11.0
6 participants
@gabrieljackson @lieut-data @jwilander @lindy65 @hanzei @amyblais