This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Update PULL_REQUEST_TEMPLATE.md #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `Ran `make check-style` to check for style errors (required for all pull requests)` and fixes localization file location
1 task
jwilander
approved these changes
Nov 8, 2017
jwilander
added
4: Reviews Complete
esethna
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
…move member events (#258) * add telemetry for api channels add/join/add/remove member events * retain api tracking and change type/prefix of action events
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
…move member events (#258) * add telemetry for api channels add/join/add/remove member events * retain api tracking and change type/prefix of action events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Ran `make check-style` to check for style errors (required for all pull requests)and fixes localization file locationPeople keep hitting style errors, which are most often identified by running
make check-style.Also an accompanying docs PR here: mattermost/docs#1615