Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fixing some i18n missed strings #2563

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

jespino
Copy link
Member

@jespino jespino commented Mar 29, 2019

Summary

Adding the english translation for some missed strings and removing an unussed constant with its translation.

@jespino jespino requested review from cpanato and enahum March 29, 2019 10:03
@jespino jespino added the 2: Dev Review Requires review by a core commiter label Mar 29, 2019
@jespino jespino added this to the v5.10.0 milestone Mar 29, 2019
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Mar 29, 2019
@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 1, 2019
@jespino jespino merged commit ddba011 into mattermost:master Apr 1, 2019
jespino added a commit that referenced this pull request Apr 1, 2019
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Apr 1, 2019
@jespino jespino deleted the fixing-i18n branch April 1, 2019 17:31
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 1, 2019
thekiiingbob pushed a commit to thekiiingbob/mattermost-webapp that referenced this pull request Apr 2, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
5 participants