This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14791 Safari and FF scroll correction issue when loading more posts #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing jump to the right post when loading more posts
sudheerDev
commented
Mar 28, 2019
| @@ -21,6 +21,9 @@ const POSTS_PER_PAGE = Constants.POST_CHUNK_SIZE / 2; | |||
| const MAX_NUMBER_OF_AUTO_RETRIES = 3; | |||
|
|
|||
| const MAX_EXTRA_PAGES_LOADED = 10; | |||
| const OVERSCAN_COUNT_BACKWARD = window.OVERSCAN_COUNT_BACKWARD || 50; // Exposing the value for PM to test will be removed soon | |||
There was a problem hiding this comment.
Addidng these so @esethna can change them on the fly to check the optimal values
saturninoabril
approved these changes
Mar 28, 2019
| @@ -21,6 +21,9 @@ const POSTS_PER_PAGE = Constants.POST_CHUNK_SIZE / 2; | |||
| const MAX_NUMBER_OF_AUTO_RETRIES = 3; | |||
|
|
|||
| const MAX_EXTRA_PAGES_LOADED = 10; | |||
| const OVERSCAN_COUNT_BACKWARD = window.OVERSCAN_COUNT_BACKWARD || 50; // Exposing the value for PM to test will be removed soon | |||
| const OVERSCAN_COUNT_FORWARD = window.OVERSCAN_COUNT_FORWARD || 100; // Exposing the value for PM to test will be removed soon | |||
| const HEIGHT_TRIGGER_FOR_MORE_POSTS = window.HEIGHT_TRIGGER_FOR_MORE_POSTS || 1000; // Exposing the value for PM to test will be removed soon | |||
enahum
approved these changes
Mar 28, 2019
enahum
added
4: Reviews Complete
sudheerDev
added
the
CherryPick/Approved
sudheerDev
added a commit
that referenced
this pull request
Mar 28, 2019
…sing jump to the right post when loading more posts (#2556)
sudheerDev
added
CherryPick/Done
sudheerDev
added a commit
that referenced
this pull request
Mar 28, 2019
sudheerDev
added a commit
that referenced
this pull request
Mar 28, 2019
sudheerDev
added a commit
that referenced
this pull request
Mar 28, 2019
|
reverting from both master and release branch |
amyblais
added
Changelog/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…sing jump to the right post when loading more posts (mattermost#2556)
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…tion causing jump to the right post when loading more posts (mattermost#2556)" (mattermost#2560) This reverts commit 742f772.
thekiiingbob
pushed a commit
to thekiiingbob/mattermost-webapp
that referenced
this pull request
Apr 2, 2019
…sing jump to the right post when loading more posts (mattermost#2556)
thekiiingbob
pushed a commit
to thekiiingbob/mattermost-webapp
that referenced
this pull request
Apr 2, 2019
…tion causing jump to the right post when loading more posts (mattermost#2556)" (mattermost#2560) This reverts commit 742f772.
lindy65
removed
the
4: Reviews Complete
ogi-m
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is part of #2551
Safari and FF takes an extra frame for scroll correction causing jump to the right post when loading more posts
This happens because of an requestAnimationFrame added for correction which is only needed for chrome. Chrome does not correct the scroll position at times without request animation frame and loads another set of posts before correcting. requesting another frame prevents this behaviour but causes jump for other browsers
Solution: Use request animation frame callback only for chrome
mattermost/react-window@71be4d8
Ticket Link
MM-14791