Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-14375] Fix flaky E2E tests #2544

Merged
merged 3 commits into from
Mar 29, 2019
Merged

[MM-14375] Fix flaky E2E tests #2544

merged 3 commits into from
Mar 29, 2019

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented Mar 27, 2019

Summary

Fix flaky E2E tests

Not critical for v5.10 release but labelled since it's scheduled for it 馃槃.

Ticket Link

Jira: MM-14375

@saturninoabril saturninoabril added the 2: Dev Review Requires review by a core commiter label Mar 27, 2019
@saturninoabril saturninoabril added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Mar 27, 2019
Copy link
Collaborator

@cometkim cometkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still can be avoided?

cypress/support/commands.js Outdated Show resolved Hide resolved
@saturninoabril
Copy link
Member Author

@cometkim ready for another review, thanks

@cometkim
Copy link
Collaborator

Changes LGTM :)

@migbot migbot removed the 2: Dev Review Requires review by a core commiter label Mar 28, 2019
@saturninoabril saturninoabril added this to the v5.10.0 milestone Mar 29, 2019
@saturninoabril saturninoabril merged commit 18ddce3 into mattermost:master Mar 29, 2019
@saturninoabril saturninoabril deleted the MM-14375-2 branch March 29, 2019 08:23
saturninoabril added a commit that referenced this pull request Mar 29, 2019
* fix flaky E2E tests

* added suggestion from @cometkim

Co-Authored-By: saturninoabril <[email protected]>

* updated per suggestion
@saturninoabril saturninoabril added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 29, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 29, 2019
stevepartridge pushed a commit to stevepartridge/mattermost-webapp that referenced this pull request Mar 30, 2019
* fix flaky E2E tests

* added suggestion from @cometkim

Co-Authored-By: saturninoabril <[email protected]>

* updated per suggestion
thekiiingbob pushed a commit to thekiiingbob/mattermost-webapp that referenced this pull request Apr 2, 2019
* fix flaky E2E tests

* added suggestion from @cometkim

Co-Authored-By: saturninoabril <[email protected]>

* updated per suggestion
@lindy65 lindy65 added the Tests/Not Needed Does not require new release tests label Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
5 participants