This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14579 Correctly size AutosizeTextarea on mount #2531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depending on the order of events when the post/comment textboxes were being mounted, sometimes the height of the textbox would not be set due to races with when the
post-create
div was mounted. I removed the use of jquery to add a class name and instead used state in the CreatePost and CreateComment components to add the class as needed and made sure to call the size calculation on textbox mount.Ticket Link
https://mattermost.atlassian.net/browse/MM-14579
Checklist
make check-style
to check for style errors (required for all pull requests)make test
to ensure unit and component tests passed