This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14341 Add client-side messageWillBePosted hook #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hmhealey, Thanks for requesting my review, but I'm not familiar enough with react to review this. I will defer to @crspeller. |
|
@levb Could you please help out and review this PR? Lev is OOO atm and this should go into 5.10. |
jespino
reviewed
Mar 25, 2019
crspeller
suggested changes
Mar 25, 2019
|
|
||
| if (hookResult.error) { | ||
| this.setState({ | ||
| serverError: hookResult.error, |
There was a problem hiding this comment.
The name is bad, but I didn't want to go through with changing it elsewhere. Ideally, I think we'd just have one "error" state that controls the error message instead of multiple different fields depending on where the error came from, but seeing as there's already this.state.serverError and this.state.textError, I didn't want to add another one.
|
A quick reminder that tomorrow (v5.10 Feature Complete) is the last day to merge feature PRs if we want this for v5.10. |
crspeller
approved these changes
Mar 25, 2019
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
* MM-14341 Add client-side messageWillBePosted hook * Fix and add another test * Update CreatePost unit tests * Handle falsey results from MessageWillBePosted hooks
This was referenced May 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook is needed for the NPS plugin because we wanted to show a confirmation modal for written feedback so that users know their feedback is being sent to Mattermost.
Ticket Link
https://mattermost.atlassian.net/browse/MM-14341
Checklist