MM-13542 Cypress test for Open edit modal immediately after making a … #2522
Conversation
There was a problem hiding this comment.
Thanks @sapnasivakumar, looks good to me. Could you please add ID to Edit Post modal like id='editPostModal' so that we'll be able to check its visibility on esc and uparrow?
| @@ -61,4 +61,39 @@ describe('Edit Message', () => { | |||
| // * Assert emoji picker is not visible | |||
| cy.get('#emojiPicker').should('not.exist'); | |||
| }); | |||
|
|
|||
| it('Edit modal should open for the first post when the second post is still pending', () => { | |||
There was a problem hiding this comment.
| it('Edit modal should open for the first post when the second post is still pending', () => { | |
| it('M13542 Open edit modal immediately after making a post', () => { |
Please update the description to include the test key M13542. We recently used that to track between codebase and list of test cases.
8f5657e
to
9d562e3
Compare
|
@sapnasivakumar Please update the test specs to reflect the updated test steps/verification from Github issue. |
@saturninoabril I'll update the tests according to the new changes and send it over. Thank you for intimating me |
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
Hey @sapnasivakumar, Do you have questions about the above provided feedback? |
@hanzei I've done the changes taking into account the feedback given |
096b382
to
55b0864
Compare
|
@saturninoabril I've updated the PR as per the feedback. Kindly have a look |
There was a problem hiding this comment.
@sapnasivakumar thanks for the update. Just last comments from me and I'm good with it.
55b0864
to
555dcd5
Compare
555dcd5
to
a540924
Compare
a540924
to
7fb2fa1
Compare
7fb2fa1
to
b533c16
Compare
b533c16
to
28c1cc7
Compare
28c1cc7
to
7ae3490
Compare
| // 3. Post a second message "World!" | ||
| // 4. Hit 'enter' key and then immediately (as FAST as you can) hit 'arrow-up' to open the edit box | ||
| cy.get('#post_textbox').type('World!{enter}{uparrow}'); | ||
| cy.get('#edit_textbox').invoke('val').then((val) => { // eslint-disable-line |
|
@bradjcoughlin Could you please review, when you have the time? |
|
Thanks for the PR @sapnasivakumar! 🎉 |
…post
Summary
This test is used to check if the edit modal is opened for a previous post when the latest one is still pending.
As we are not able to throttle the network to mimic this condition on realtime using cypress, I've handled the case using some conditional testing.
Ticket Link
mattermost/mattermost#10040
Checklist
make check-styleto check for style errors (required for all pull requests)