This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-14591] Add hide prop to profile popover from the at_mention component #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonblais
added
1: PM Review
jasonblais
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Tested opening popover via username, profile pic and at-mention, both in center channel and right-hand side thread panel.
Looks great, thanks @mickmister!
jasonblais
added
2: Dev Review
4 tasks
|
@mickmister, when you have a minute, can you please merge master into your branch and then push back up? |
…ose-profile-popover-on-at-mention
|
@deanwhillier done 👍 |
|
Awesome, thanks @mickmister! |
deanwhillier
added
4: Reviews Complete
amyblais
added
Changelog/Done
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
lindy65
added
Tests/Not Needed
mickmister
deleted the
issue/MM-14591-close-profile-popover-on-at-mention
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This solves the issue where the profile popover cannot close itself when opened from an "@ mention."
Ticket Link
Fixes mattermost/mattermost#10454
Jira Ticket
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed