This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
iOS (Mobile Safari) - Keyboard covers up messages after orientation c… #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonblais
added
1: PM Review
esethna
added
Setup Old Test Server
esethna
added
2: Dev Review
enahum
approved these changes
Mar 22, 2019
saturninoabril
approved these changes
Mar 25, 2019
|
@csduarte Please help rebase so we can merge, thanks! |
…void overlaying chat messages
dseawel
force-pushed
the
keyboard-overlay-orientation-change
branch
from
e271be3
to
bd0fa2b
Compare
|
@saturninoabril This should be ready now. |
|
Thanks @dseawel 💯 |
amyblais
added
Changelog/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…void overlaying chat messages (mattermost#2504)
lindy65
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change addresses an issue for iOS Mobile Safari where, after screen orientation is changed, the keyboard overlays most recent messages in the window and user cannot scroll down to see them. The window will now hide the keyboard on orientation change for this scenario.
Ticket Link
N/a
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed