Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-8056 Minor text updates for DND status #249

Merged
merged 5 commits into from
Nov 8, 2017
Merged

PLT-8056 Minor text updates for DND status #249

merged 5 commits into from
Nov 8, 2017

Conversation

jwilander
Copy link
Member

Summary

Minor text updates for DND status. @asaadmahmood can you help with the spacing/font size for status dropdown?

Ticket Link

https://mattermost.atlassian.net/browse/PLT-8056

@jwilander jwilander added the 1: PM Review Requires review by a product manager label Nov 6, 2017
@esethna esethna added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Nov 6, 2017
@mattermost mattermost deleted a comment from mattermod Nov 6, 2017
@mattermost mattermost deleted a comment from mattermod Nov 6, 2017
@mattermost mattermost deleted a comment from mattermod Nov 6, 2017
@esethna esethna added this to the v4.4.0 milestone Nov 6, 2017
@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Nov 6, 2017
@esethna
Copy link
Contributor

esethna commented Nov 6, 2017

Adding @crspeller to help look into the spinmint issue

@crspeller crspeller removed the Setup Old Test Server Triggers the creation of a test server label Nov 6, 2017
@mattermost mattermost deleted a comment from mattermod Nov 6, 2017
@mattermost mattermost deleted a comment from mattermod Nov 6, 2017
@mattermost mattermost deleted a comment from mattermod Nov 6, 2017
@crspeller crspeller added the Setup Old Test Server Triggers the creation of a test server label Nov 6, 2017
@esethna
Copy link
Contributor

esethna commented Nov 6, 2017 •
edited
Loading

Thanks Joram, looks good, I've alerted @asaadmahmood on pre-release so we can get the styling updates in as soon as he's back on,

@asaadmahmood
Copy link
Contributor

@esethna Submitted my changes. The status dropdown intentionally has a different padding/width due to the help text, and no sector dividers.

@jasonblais jasonblais mentioned this pull request Nov 7, 2017
Closed
@esethna esethna removed the Setup Old Test Server Triggers the creation of a test server label Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Nov 7, 2017
@jwilander
Copy link
Member Author

@esethna should I change the base to release-4.4 so this is included in the next RC?

@esethna
Copy link
Contributor

esethna commented Nov 7, 2017

@jwilander yes please!

@jasonblais jasonblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 7, 2017
@jwilander jwilander changed the base branch from master to release-4.4 November 7, 2017 18:11
@jwilander jwilander assigned crspeller and unassigned asaadmahmood Nov 7, 2017
@esethna esethna removed the Setup Old Test Server Triggers the creation of a test server label Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@mattermost mattermost deleted a comment from mattermod Nov 7, 2017
@crspeller crspeller merged commit f8c75a7 into release-4.4 Nov 8, 2017
@crspeller crspeller deleted the plt-8056 branch November 8, 2017 20:05
@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Nov 9, 2017
@mattermost mattermost deleted a comment from mattermod Nov 9, 2017
@esethna esethna added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Nov 9, 2017
@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-0d96c084460e85886.spinmint.com

Test Account 1: Email: [email protected] | Password: passwd

Test Account 2: Email: [email protected] | Password: passwd

Instance ID: i-0d96c084460e85886

@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Nov 9, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 10, 2017
@hmhealey hmhealey removed the Setup Old Test Server Triggers the creation of a test server label Nov 21, 2017
@mattermod
Copy link
Contributor

Spinmint test server destroyed

hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@enahum @hmhealey
RN-338 Only save open graph data if it has a description (#249)
f5bc64f
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@enahum @jwilander
RN-338 Only save open graph data if it has a description (#249)
e6b60fc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grundleborg grundleborg grundleborg approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

@esethna esethna esethna approved these changes

Assignees

@crspeller crspeller

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v4.4.0
Development

Successfully merging this pull request may close these issues.
10 participants
@jwilander @esethna @asaadmahmood @mattermod @grundleborg @saturninoabril @crspeller @hmhealey @jasonblais @lindalumitchell