This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-14491] avoid hiding the popover when the cursor is moved away fro… #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
approved these changes
Mar 11, 2019
asaadmahmood
approved these changes
Mar 12, 2019
|
Hi @kosgrz - do you have sample data I can populate the spinmint with that includes a link with a pop-over? |
|
Hi @lindy65 - I uploaded on the server a modified version of the Demo Plugin with a button in the popover. I also pasted some text in the "Town square" channel with a link to test. |
|
Thank you @kosgrz ! Tested on the spinmint - hovering over the link in the text causes the pop-up to display and I am able to move my cursor to the pop-up to click on the button. Looks good to me, thanks again! |
|
@crspeller - I think this PR is good to merge :) |
lindy65
removed
2: Dev Review
…m the link to the popover
hanzei
added
the
4: Reviews Complete
|
Thanks @kosgrz for the contribution! |
amyblais
added
Changelog/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…m the link to the popover (mattermost#2472)
lindy65
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m the link to the popover
Summary
Gifs to illustrate the change:
Before
After
Ticket Link
(Jira ticket)[https://mattermost.atlassian.net/browse/MM-14491] | Fixes GitHub issue #10424
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed