Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-14334 Allow plugin setting help text to contain Markdown #2467

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Mar 8, 2019

This adds the ability for non-translated text (mainly text coming from a plugin) to contain markdown and moves the logic for rendering that help text into its own component. It's needed for the NPS plugin.

Ticket Link

https://mattermost.atlassian.net/browse/MM-14334

Checklist

  • Added or updated unit tests
  • Has UI changes

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Mar 8, 2019
@hmhealey hmhealey added this to the v5.10.0 milestone Mar 8, 2019
@hmhealey hmhealey requested review from jespino and mkraft March 8, 2019 16:59
Copy link
Contributor

@mkraft mkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Mar 8, 2019
@jespino jespino merged commit 92d440a into master Mar 8, 2019
@jespino jespino deleted the mm14334a branch March 8, 2019 17:31
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 19, 2019
stevepartridge pushed a commit to stevepartridge/mattermost-webapp that referenced this pull request Mar 30, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
5 participants