MM-13741 Load user after setting up MFA on login or sign up #2464
Conversation
components/mfa/confirm/index.js
Outdated
| return { | ||
|
|
||
| // Assume we need to load the user if they don't have any team memberships loaded | ||
| shouldLoadUser: isEmptyObject(getTeamMemberships(state)), |
There was a problem hiding this comment.
In the case that the user is truly not on any teams and has already loaded all their data (not sure how they'd get into that state) then this might cause an extra few HTTP requests to load the user's data again. In 99.9% of the cases though if their team memberships are empty, they likely need to load all their data.
There was a problem hiding this comment.
It's unfortunate that the Confirm component has to "know" about this. And I presume this fix might actually help in other invocations to redirectUserToDefaultTeam? What if we moved the empty test into that action instead?
There was a problem hiding this comment.
That's actually a really good idea. Let me try that 👍
components/mfa/confirm/index.js
Outdated
| return { | ||
|
|
||
| // Assume we need to load the user if they don't have any team memberships loaded | ||
| shouldLoadUser: isEmptyObject(getTeamMemberships(state)), |
There was a problem hiding this comment.
It's unfortunate that the Confirm component has to "know" about this. And I presume this fix might actually help in other invocations to redirectUserToDefaultTeam? What if we moved the empty test into that action instead?
|
Ready for re-review |
amyblais
added
Changelog/Done
lindy65
added
Tests/Not Needed
…st#2464) * Load user after setting up MFA on login or sign up * Move load user logic into redirectUserToDefaultTeam * Clean up unit test
Summary
This will fix a user not being redirected to the correct place after logging and being required to set up MFA (due it being enforced) and it will make sure that the user loads all the data the client assumes has been loaded after login.
Ticket Link
https://mattermost.atlassian.net/browse/MM-13741
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed