Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-13694] Modify helper text of SiteName config field to specify the default value #2446

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

mgdelacroix
Copy link
Member

Summary

This PR modifies the helper text of the SiteName config field to specify the default value that will be set if the field is left empty.

Ticket Link

MM-13694

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Has server changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@mgdelacroix mgdelacroix added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter labels Mar 5, 2019
Copy link
Contributor

@wiersgallak wiersgallak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core commiter labels Mar 6, 2019
@mgdelacroix mgdelacroix merged commit 91fa98a into mattermost:master Mar 7, 2019
@mgdelacroix mgdelacroix deleted the mm-13694 branch March 7, 2019 11:53
@lindalumitchell lindalumitchell added this to the v5.10.0 milestone Mar 7, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Mar 9, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 19, 2019
stevepartridge pushed a commit to stevepartridge/mattermost-webapp that referenced this pull request Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants