[MM-14278] Display same recent emoji only once

[bradjcoughlin]

Summary

• A recent change had recent emojis stored by alias, resulting in identical emoji such as :thumbsup: or :+1: to be displayed twice
• This reverts that change to store by the first alias only, de-duplicating the recent history
• Additionally, emoji.id was undefined, using emojiIndex instead. No real impact with the above fix applied, but this prevents the indices from showing 1f609:undefined for example.

Ticket Link

https://mattermost.atlassian.net/browse/MM-14278

Checklist

• Ran make check-style to check for style errors (required for all pull requests)
• Ran make test to ensure unit and component tests passed
• Has UI changes

[lieut-data]

Thanks for digging into this, @bradjcoughlin! Looks like this line was changed as part of #2224. Can you comment on whether the functionality of that PR is maintained with your changes?

[bradjcoughlin]

@lieut-data from my testing, it appears that the following logic/functionality still works as expected from #2224:

• First, display recently used emoji that match the search term, in alphabetical order
• Second, display emoji that start with the search term, in alphabetical order
• Last, display emoji that contain the search term, in alphabetical order.

[lieut-data]

Sounds good! Are there unit tests we can update here?

[bradjcoughlin]

@lieut-data I believe so. Specifically related to this PR, I could add a test verifying the first alias is returned in recent emojis even if an alternative alias was used.

This tests seems to be checking only the primary alias.

mattermost-webapp/actions/emoji_actions.test.js

Lines 16 to 21 in 0de0500

	it('addRecentEmoji', async () => {
	store.dispatch(Actions.addRecentEmoji('grinning'));
	assert.ok(getRecentEmojis(store.getState()).includes('grinning'));
	store.dispatch(Actions.addRecentEmoji('joramwilander'));
	assert.ok(!getRecentEmojis(store.getState()).includes('joramwilander'));
	});