This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14104 Update logic for Markdown emphasis from upstream #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
saturninoabril
approved these changes
Feb 27, 2019
|
Looks like the update is causing some tests to fail. @hmhealey is investigating. |
|
Fixed. Turns out we were previously using a branch on the marked fork, and switching to the master branch on it lost some changes. I merged those into master and updated the commit. Also, one of the tests was legitimately broken |
deanwhillier
approved these changes
Feb 28, 2019
deanwhillier
added
4: Reviews Complete
hmhealey
added a commit
that referenced
this pull request
Feb 28, 2019
hmhealey
added
CherryPick/Done
amyblais
added
Changelog/Done
lindy65
added
Tests/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…#2414) * MM-14104 Update logic for Markdown emphasis from upstream * Fix accidentally reverted marked changes * Update unintentionally improved unit test
tuannguyen041094
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Apr 9, 2019
…#2414) * MM-14104 Update logic for Markdown emphasis from upstream * Fix accidentally reverted marked changes * Update unintentionally improved unit test
tuannguyen041094
pushed a commit
to Designveloper/mattermost-webapp
that referenced
this pull request
Apr 21, 2019
…#2414) * MM-14104 Update logic for Markdown emphasis from upstream * Fix accidentally reverted marked changes * Update unintentionally improved unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, we don't have our marked fork up to date with upstream because we've made some extensive changes to it internally. Since the goal is still to switch to commonmark.js, there haven't been many efforts to get it up to date, but occasionally we need to manually copy changes like this to fix annoying bugs.
The actual changes for this PR are here: mattermost/marked@c1b6989
Ticket Link
https://mattermost.atlassian.net/browse/MM-14104