This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-14242] Remove props such as lastPostCount, idCount and idPrefix which were previously used for Se E2E #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
requested review from
migbot,
sudheerDev and
jespino
and removed request for
sudheerDev
jespino
reviewed
Feb 27, 2019
tests/setup.js
Outdated
| @@ -64,7 +64,7 @@ beforeEach(() => { | |||
|
|
|||
| afterEach(() => { | |||
| if (logs.length > 0 || warns.length > 0 || errors.length > 0) { | |||
| throw new Error('Unexpected console logs' + logs + warns + errors); | |||
| // throw new Error('Unexpected console logs' + logs + warns + errors); | |||
There was a problem hiding this comment.
Oops, sorry, nice catch. That's for my own debugging only. Will revert that.
There was a problem hiding this comment.
Thanks @jespino, now updated.
jespino
reviewed
Feb 27, 2019
…reviously used for Se E2E
migbot
approved these changes
Feb 28, 2019
amyblais
added
Changelog/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…hich were previously used for Se E2E (mattermost#2410) * Remove props such as lastPostCount, idCount and idPrefix which were previously used for Se E2E * revert commented out test setup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to some limitation of Se to identify post ID, dynamic IDs for Post component were introduced to make the last post/s be testable. Props were added for that purpose such as lastPostCount, idCount and idPrefix. However, those dynamic IDs were eventually disabled due to unnecessary re-rendering of components on change of props (counts changed whenever new post/s arrived/submitted). Related Se tests were eventually either disabled or put on manual tests.
With Cypress, we have now the ability to get post ID like
cy.getLastPostId()or in the future we can add command likecy.getPostId(xNumberFromRecent).This PR removed props such as lastPostCount, idCount and idPrefix. This also aimed to organize how to assign ID into a component. Naming convention is like
[location]_[name]_[post_id]where location is either on CENTER, RHS_ROOT, RHS_COMMENT or SEARCH.Ticket Link
Jira ticket: MM-14242
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed