This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-10516: Added interactive action support to ephemeral messages #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preserve the cookie in PostActions - Replaced doPostAction with doPostActionWithCookie
1 task
jasonblais
approved these changes
Feb 9, 2019
There was a problem hiding this comment.
Thanks Lev!
Approving changes as-is. As noted on the server PR, we would test with the Giphy plugin once this PR has been merged (along with Redux). So I will do testing there and provide client-side feedback there.
I can also test the Giphy plugin on mobile to see if a mobile PR needs to be submitted.
|
How can I do a "E2E" on this feature? Does updating the redux hash in |
|
crspeller
approved these changes
Feb 12, 2019
|
Thanks @levb for the hint. 👍 Got my local setup working. |
added 4 commits
February 14, 2019 13:16
crspeller
approved these changes
Feb 20, 2019
jespino
approved these changes
Feb 21, 2019
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
…termost#2351) * MM-10516: Added interactive action support to ephemeral messages - Preserve the cookie in PostActions - Replaced doPostAction with doPostActionWithCookie * Updated mattermost-redux include to the supporting changes. mattermost/mattermost-redux@aa1b7f5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR supports adding interactive actions to ephemeral messages. The client now recognizes "action cookies" that are sent by mattermost-server included in PostAction's; It stores them and sends them back to the server when submitting DoPostActionRequest.
Ticket Link
https://mattermost.atlassian.net/browse/MM-10516
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passedSee Also: