This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-13924 Ensure OpenGraph and message attachment images go through the proxy #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
crspeller
approved these changes
Feb 4, 2019
sudheerDev
added
4: Reviews Complete
|
@hmhealey Sorry for the delay. I overlooked this from my review queue. |
hmhealey
added a commit
that referenced
this pull request
Feb 7, 2019
…e proxy (#2331) Doing this on the app instead of the server because it might otherwise cause problems when we're requesting image dimensions. I was looking at a more generic way of doing this, but this doesn't seem like the time to add it since we're just about to kick off RC testing. #### Ticket Link https://mattermost.atlassian.net/browse/MM-13924
hmhealey
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this on the app instead of the server because it might otherwise cause problems when we're requesting image dimensions. I was looking at a more generic way of doing this, but this doesn't seem like the time to add it since we're just about to kick off RC testing.
Ticket Link
https://mattermost.atlassian.net/browse/MM-13924
Checklist