Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-13761 Properly request external image through proxy when viewed in preview modal #2296

Merged
merged 2 commits into from
Jan 31, 2019
Merged

MM-13761 Properly request external image through proxy when viewed in preview modal #2296

merged 2 commits into from
Jan 31, 2019

Conversation

hmhealey
Copy link
Member

This one use of an external image link wasn't being passed through the proxy by either the server or web app, so we'll now make sure to do that before passing it to the ViewImageModal.

Ticket Link

https://mattermost.atlassian.net/browse/MM-13761

Checklist

  • Added or updated unit tests (required for all new features).)

@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 29, 2019
@hmhealey hmhealey added this to the v5.8.0 milestone Jan 29, 2019
deanwhillier
deanwhillier approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@deanwhillier deanwhillier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me however, I'm not too familiar with this functionality yet, so another approval would probably be good. :)

One minor comment above.

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jan 31, 2019
@hmhealey hmhealey self-assigned this Jan 31, 2019
@hmhealey hmhealey closed this Jan 31, 2019
@hmhealey hmhealey reopened this Jan 31, 2019
@cpanato cpanato closed this Jan 31, 2019
@cpanato cpanato reopened this Jan 31, 2019
@hmhealey hmhealey merged commit 23e4b2b into master Jan 31, 2019
@hmhealey hmhealey deleted the mm13761 branch January 31, 2019 17:55
hmhealey added a commit that referenced this pull request Jan 31, 2019
@hmhealey
MM-13761 Properly request external image through proxy when viewed in…
1114047 
… preview modal (#2296)

* MM-13761 Properly request external image through proxy when viewed in preview modal

* Fix typo
@hmhealey hmhealey added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jan 31, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Feb 1, 2019
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crspeller crspeller crspeller approved these changes

@deanwhillier deanwhillier deanwhillier approved these changes

Assignees

@hmhealey hmhealey

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.8.0
6 participants
@hmhealey @crspeller @deanwhillier @cpanato @amyblais @DHaussermann