Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-13811] fixes wrong stylings on several modals #2280

Merged
merged 3 commits into from
Jan 30, 2019
Merged

[MM-13811] fixes wrong stylings on several modals #2280

merged 3 commits into from
Jan 30, 2019

Conversation

svelle
Copy link
Member

@svelle svelle commented Jan 24, 2019

Summary

fixes the wrong button styling on several modals in the webapp (see jira ticket fore examples)

Ticket Link

https://mattermost.atlassian.net/browse/MM-13811

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Needs to be implemented in mobile (link to PR or User Story)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@hanzei hanzei added the 2: Dev Review Requires review by a core commiter label Jan 24, 2019
@esethna esethna added this to the v5.8.0 milestone Jan 29, 2019
@esethna esethna changed the title fixes wrong stylings on several modals [MM-13811] fixes wrong stylings on several modals Jan 29, 2019
@asaadmahmood
Copy link
Contributor

@svelle Needs a rebase.

@svelle
Copy link
Member Author

svelle commented Jan 30, 2019

@svelle Needs a rebase.

is it good like this, or do you want all changes in a single commit?

@sudheerDev
Copy link
Contributor

@svelle All good. Thanks 👍

@sudheerDev sudheerDev merged commit b6cd19f into mattermost:master Jan 30, 2019
sudheerDev pushed a commit that referenced this pull request Jan 30, 2019
@svelle @sudheerDev
[MM-13811] fixes wrong stylings on several modals (#2280)
30fcc09 
* fix wrong styling on several modals

* update test snapshots
@sudheerDev sudheerDev added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jan 30, 2019
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 31, 2019
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sudheerDev sudheerDev sudheerDev approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

@asaadmahmood asaadmahmood asaadmahmood approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.8.0
8 participants
@svelle @asaadmahmood @sudheerDev @saturninoabril @lindy65 @esethna @hanzei @amyblais