This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[GH-10035] Added the cypress spec for cancel out leave a team modal #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fc01d0
to
ebf2644
Compare
saturninoabril
suggested changes
Jan 3, 2019
There was a problem hiding this comment.
Thanks @pradeepmurugesan! 🎉
Made some comments to satisfy: "Expected: Modal closes, user is still on team, still viewing team, no changes"
ebf2644
to
b3b6735
Compare
|
@saturninoabril made the changes. Kindly review |
b3b6735
to
508eb4d
Compare
saturninoabril
approved these changes
Jan 4, 2019
sudheerDev
approved these changes
Jan 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the cypress test for the case "cancel out leave a team modal"
Ticket Link
mattermost/mattermost#10035
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed