Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-13271 Fix for Leave team making 403 calls #2187

Merged
merged 2 commits into from
Dec 12, 2018
Merged

MM-13271 Fix for Leave team making 403 calls #2187

merged 2 commits into from
Dec 12, 2018

Conversation

sudheerDev
Copy link
Contributor

@sudheerDev sudheerDev commented Dec 12, 2018 •
edited
Loading

Summary

Fixes leave team making 403 calls.
Using redux actions instead of team_action in web for just removing a user or to leave a team

manage_members in team uses team_action in web so team and channel stats can be updated
manage_teams in admin console does not require channel and team stat calls so using redux action instead

Ticket Link

MM-13271

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)

@sudheerDev sudheerDev added the 2: Dev Review Requires review by a core commiter label Dec 12, 2018
@sudheerDev sudheerDev added this to the v5.7.0 milestone Dec 12, 2018
@sudheerDev
MM-13271 Fix for Leave team making 403 calls
998c6d9 
  * Leave team should not call for stat calls
  * removeUserFromTeam be used for remvoving user and to get stats
@sudheerDev
* Rename removeUserFromTeam action to removeUserFromTeamAndGetStats
a1c7663
@saturninoabril saturninoabril merged commit d6b882c into mattermost:master Dec 12, 2018
@saturninoabril saturninoabril added Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) and removed 2: Dev Review Requires review by a core commiter labels Dec 12, 2018
@sudheerDev sudheerDev deleted the MM-13271 branch December 18, 2018 17:09
sudheerDev added a commit that referenced this pull request Dec 18, 2018
@sudheerDev
MM-13271 Fix for Leave team making 403 calls (#2187)
ca649c1 
* MM-13271 Fix for Leave team making 403 calls

  * Leave team should not call for stat calls
  * removeUserFromTeam be used for remvoving user and to get stats

* * Rename removeUserFromTeam action to removeUserFromTeamAndGetStats
@sudheerDev sudheerDev added CherryPick/Approved Meant for the quality or patch release tracked in the milestone CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone labels Dec 18, 2018
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Dec 18, 2018
@lindalumitchell lindalumitchell removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Dec 28, 2018
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jan 1, 2019
@JtheBAB JtheBAB mentioned this pull request Jan 15, 2019
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.7.0
6 participants
@sudheerDev @jwilander @saturninoabril @lindalumitchell @amyblais @DHaussermann