Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Multiple Bug fixes #216

Merged
merged 10 commits into from
Nov 6, 2017
Merged

Multiple Bug fixes #216

merged 10 commits into from
Nov 6, 2017

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Oct 30, 2017 •
edited
Loading

Please make sure you've read the pull request section of our code contribution guidelines.

When filling in a section please remove the help text and the above text.

Summary

PLT-7977 - Emoji icon overlapping in edit modal
PLT-7965 - Channel header underline fix
PLT-7985 - Fixing more unreads indicator text
PLT-7282 - Adding @ sign before username in modals
PLT-6828 - Hiding url links for clickable elements
PLT-7928 - Pinned post button position fix
PLT-8000 - Long DM name not truncating
PLT-8033 - Fixing manage members button on mobile

Ticket Link

https://mattermost.atlassian.net/browse/PLT-7977
https://mattermost.atlassian.net/browse/PLT-7965
https://mattermost.atlassian.net/browse/PLT-7985
https://mattermost.atlassian.net/browse/PLT-7282
https://mattermost.atlassian.net/browse/PLT-6828
https://mattermost.atlassian.net/browse/PLT-7928
https://mattermost.atlassian.net/browse/PLT-8000
https://mattermost.atlassian.net/browse/PLT-8033

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json and .../webapp/i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@coreyhulen coreyhulen added 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Oct 30, 2017
@jasonblais jasonblais added this to the v4.4.0 milestone Oct 31, 2017
@jasonblais
Copy link
Contributor

jasonblais commented Nov 1, 2017 •
edited
Loading

@asaadmahmood

  1. Flagged post icon shows URL when RHS is open
    image

  2. Team icons still show a URL on hover in the desktop app (messaged you on pre-release since it's part of a separate ticket)

  3. In Integrations > Incoming Webhooks (and other integration pages), the "Edit" button still shows a URL on hover

  4. "Load more messages" shows the URL

  5. Channel header should be underlined when it's not set and you're hovering over "Add a channel description"
    image

jasonblais
jasonblais suggested changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@jasonblais jasonblais self-assigned this Nov 1, 2017
@asaadmahmood
Copy link
Contributor Author

  1. Fixed.
  2. Not related to my changes, will probably be addressed by Saturn.
  3. The edit link actually has a valid href attribute rather than just a "#".
  4. Done.
  5. Done.

1 similar comment
@asaadmahmood
Copy link
Contributor Author

  1. Fixed.
  2. Not related to my changes, will probably be addressed by Saturn.
  3. The edit link actually has a valid href attribute rather than just a "#".
  4. Done.
  5. Done.

@asaadmahmood
Copy link
Contributor Author

Hey @jasonblais have a look.

@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Nov 2, 2017
@mattermost mattermost deleted a comment from mattermod Nov 2, 2017
@mattermost mattermost deleted a comment from mattermod Nov 2, 2017
@mattermost mattermost deleted a comment from mattermod Nov 2, 2017
@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Nov 2, 2017
@jasonblais
Copy link
Contributor

@asaadmahmood Above fixes look good, except the channel dropdown is misplaced now

image

@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Nov 5, 2017
@mattermost mattermost deleted a comment from mattermod Nov 5, 2017
@mattermost mattermost deleted a comment from mattermod Nov 5, 2017
@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Nov 5, 2017
jasonblais
jasonblais approved these changes Nov 5, 2017
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Queuing for last dev review.

@asaadmahmood This will need one more rebase before it can be merged.

@jasonblais jasonblais removed their assignment Nov 5, 2017
@mattermost mattermost deleted a comment from mattermod Nov 5, 2017
@mattermost mattermost deleted a comment from mattermod Nov 5, 2017
@mattermost mattermost deleted a comment from mattermod Nov 5, 2017
@crspeller crspeller merged commit 89a70f1 into mattermost:master Nov 6, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 7, 2017
@jasonblais jasonblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 10, 2017
@asaadmahmood asaadmahmood deleted the bug-fixes branch November 11, 2017 02:04
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@jwilander @hmhealey
PLT-7237 Remove failed post if commenting on deleted parent post (#216)
55fb9ec 
* Remove failed post if commenting on deleted parent post

* Dispatch post failures to request store
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@jwilander
PLT-7237 Remove failed post if commenting on deleted parent post (#216)
a0d4259 
* Remove failed post if commenting on deleted parent post

* Dispatch post failures to request store
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MusikPolice MusikPolice MusikPolice approved these changes

@crspeller crspeller crspeller approved these changes

@jasonblais jasonblais jasonblais approved these changes

@hmhealey hmhealey Awaiting requested review from hmhealey

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.4.0
6 participants
@asaadmahmood @jasonblais @MusikPolice @crspeller @coreyhulen @lindalumitchell