Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Always generate full source map. #2126

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Always generate full source map. #2126

merged 1 commit into from
Dec 3, 2018

Conversation

crspeller
Copy link
Member

  • Fixes CSP warnings with "quicker" source map
  • Better development experience by default

@crspeller crspeller added the 2: Dev Review Requires review by a core commiter label Dec 3, 2018
jwilander
jwilander approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it'll be nice to only have one run target

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Dec 3, 2018
@crspeller crspeller merged commit cb9dec0 into master Dec 3, 2018
@crspeller crspeller deleted the always-fullmap branch December 3, 2018 21:39
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 4, 2018
@hanzei
Copy link
Contributor

hanzei commented Dec 5, 2018

Should we remove run-fullmap from https://developers.mattermost.com/contribute/server/developer-workflow/#useful-server-makefile-commands?

@hmhealey
Copy link
Member

hmhealey commented Dec 5, 2018

Good catch, @hanzei. It also needs to be removed from the server's Makefile as well. I've made a ticket to make sure that we remember to remove those as well. We'd always appreciate help with doing that though :)

@hanzei hanzei mentioned this pull request Dec 5, 2018
Merged
@hanzei
Copy link
Contributor

hanzei commented Dec 5, 2018

I will take care of this.

@hanzei hanzei mentioned this pull request Dec 5, 2018
Merged
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Dec 14, 2018
@JtheBAB JtheBAB mentioned this pull request Jan 15, 2019
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
No milestone
6 participants
@crspeller @hanzei @hmhealey @jwilander @lindalumitchell @amyblais