This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-13209: use textbox channel from context #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids relying on a global notion of the current channel, which only applies to the centre and not the RHS.
lieut-data
added
2: Dev Review
hmhealey
reviewed
Nov 29, 2018
components/textbox/index.js
Outdated
| actions: bindActionCreators({ | ||
| autocompleteUsersInChannel, | ||
| autocompleteUsersInChannel: (prefix) => autocompleteUsersInChannel(prefix, ownProps.channelId), |
There was a problem hiding this comment.
Maybe we could just have the Textbox pass the channelId into the action when it calls it? Since it's coming from ownProps, the Textbox knows about channelId either way, and I don't have a good understanding of how ownProps works with mapDispatchToProps to know if doing this has any side effects
hmhealey
approved these changes
Nov 29, 2018
saturninoabril
approved these changes
Nov 29, 2018
amyblais
added
the
4: Reviews Complete
lieut-data
added a commit
that referenced
this pull request
Dec 3, 2018
lieut-data
added
CherryPick/Done
amyblais
added
Changelog/Not Needed
lindy65
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids relying on a global notion of the current channel, which only applies to the centre and not the RHS, fixing an issue with the autocomplete suggesting users not appropriate for the RHS.
Ticket Link
https://mattermost.atlassian.net/browse/MM-13209
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed