This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-13147] Fix for file_upload crash when mimeTypesSuffix is not present #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
changed the title
enahum
approved these changes
Nov 23, 2018
sudheerDev
added
the
Setup Old Test Server
|
|
||
| it('mime type for no suffix', () => { | ||
| assert.equal(getFileTypeFromMime('asdasd'), 'other'); | ||
| }); |
saturninoabril
approved these changes
Nov 23, 2018
saturninoabril
added
4: Reviews Complete
enahum
removed
4: Reviews Complete
|
Spintmint test server creation failed. See the logs for more information. |
|
@sudheerDev build failed |
enahum
reviewed
Nov 23, 2018
enahum
suggested changes
Nov 23, 2018
Co-Authored-By: sudheerDev <[email protected]>
Co-Authored-By: sudheerDev <[email protected]>
Co-Authored-By: sudheerDev <[email protected]>
Co-Authored-By: sudheerDev <[email protected]>
Co-Authored-By: sudheerDev <[email protected]>
|
|
enahum
approved these changes
Nov 23, 2018
|
Spinmint test server created at: https://i-077f837a25a01520b.test.spinmint.com Test Admin Account: Username: Test User Account: Username: Instance ID: i-077f837a25a01520b |
|
Spinmint test server destroyed |
enahum
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
lindy65
added
Tests/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for file_upload crash for certain mimeTypes
Ticket Link
MM-13147
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed