-
Notifications
You must be signed in to change notification settings - Fork 2.7k
dropdown action button aligned with action buttons #2029
dropdown action button aligned with action buttons #2029
Conversation
|
Spinmint test server created at: https://i-0ff914542f093313a.test.spinmint.com Test Admin Account: Username: Test User Account: Username: Instance ID: i-0ff914542f093313a |
@scottleedavis Overall this looks like a great improvement. 1 - There may now be instances where on narrower screens, the dropdowns and buttons are mixed together as attached below whereas previously they were nicely stacked one after the other But that may be okay, given the benefit we gain on wider screens. @esethna thoughts on point 1 above? 2 - Will this change need to be applied on mobile as well? Or do we leave mobile as-is, given it's a narrower screen so the menus and buttons will most likely stack vertically anyway. 3 - Can you help review the style changes for message menus below? I think they look great to me. |
Thanks @jasonblais, RE 1, given the larger horizontal real-estate on webapp I think this is fine, unless there are use cases that break the horizontal layout? Re 2: Agree, on React Native I think vertically stacking is fine given the small screen widths Re 3: Styling looks great, thanks for making those tweaks @scottleedavis. |
Spinmint test server destroyed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Eric, changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'm also going to add Asaad since he knows the styling best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I'm going to merge this as it has been approved by 2 devs, 2 PMs and UX |
Thanks for this @scottleedavis |
Great process. Thank you all. :) |
this PR was kicked off at @esethna 's request. :)
Summary
This pull request aligns interaction dropdown select buttons with action buttons, so they appear as one group/list
![reminder](https://camo.githubusercontent.com/4fa3fa995ffaf44dfd65963da342d57c9c16fdda3770c67c119a6092b39e1338/68747470733a2f2f7072652d72656c656173652e6d61747465726d6f73742e636f6d2f66696c65732f636866666568716f6766666137666134757470747064393878632f7075626c69633f683d5848545456554345715f343575475346457630345f7a48745167645f744c535a7472447a4a627032503745)
Ticket Link
This supports the 'remindbot' work of MM-10580, about aligning the styling of a reminder's buttons with that of slackbot's output.
Checklist
make check-style
to check for style errors (required for all pull requests)make test
to ensure unit and component tests passed